Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update js-interop.md #3242

Merged
merged 2 commits into from May 15, 2024
Merged

Update js-interop.md #3242

merged 2 commits into from May 15, 2024

Conversation

RicoTrevisan
Copy link
Contributor

Small update on the example code to make it a tad more obvious and more like the other examples on the page.

@RicoTrevisan
Update js-interop.md
7f34ae6 
Small update on the example code to make it a tad more obvious and more like the other examples on the page.
rhcarvalho
rhcarvalho reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💜

Thanks! Adding more context to that example makes a lot of sense, especially since it is easy to miss that the callback needs to go within the dom option.

guides/client/js-interop.md Outdated Show resolved Hide resolved
guides/client/js-interop.md Outdated Show resolved Hide resolved
@SteffenDE @rhcarvalho
Apply suggestions from code review
ae55b83 
Co-authored-by: Rodolfo Carvalho <rhcarvalho@gmail.com>
@SteffenDE SteffenDE merged commit fd4e4d9 into phoenixframework:main May 15, 2024
6 checks passed
@SteffenDE
Copy link
Collaborator

Thank you both! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhcarvalho rhcarvalho rhcarvalho left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RicoTrevisan @SteffenDE @rhcarvalho