feat: support custom redirect statuses #3204
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For SEO reasons, it can be critical to provide a
301
versus the default302
for redirects on mount.This PR allows people to pass in
status: 301
along with theirto: "/some-path"
and have the provided status code be used when redirecting.The two reasons this PR was a little more invasive than originally thought:
redirect
function in live view was setup to enforce that onlyto
orexternal
could be provided; no additional opts.Phoenix.Controller.redirect
requires the use ofput_status
versus simply passing the status as an option (I believe the latter used to be possible, but no longer is). You'll see I'm stripping the status out of the opts after the put_status call.Thanks for all you do!