Support {:halt, render_with/2} in mount hook #2961
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Dec 22, 2023
|
|
||
| {:halt, %Socket{private: %{render_with: render_with}} = socket} | ||
| when is_function(render_with) -> | ||
| {:halt, put_private(socket, :halted, true)} |
There was a problem hiding this comment.
Implementation wise, it would be best if we didn't have to look into both private/redirected. If we could unify in a single place, it would be better.
Gazler
force-pushed
the
gr-halt-execution-on-render-with
branch
from
5c69684
to
44ec6b8
Compare
Previously, it was only possible to `{:halt, redirect}` or `{:cont,
socket}` in a mount hook. This commit adds the ability to use halt if
render_with has been specified.
When both render_with and redirect are specified, an ArgumentError is
raised, as it is ambigious which should be used.
Gazler
force-pushed
the
gr-halt-execution-on-render-with
branch
from
44ec6b8
to
7f2ee49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was only possible to
{:halt, redirect}or{:cont, socket}in a mount hook. This commit adds the ability to use halt if render_with has been specified.When both render_with and redirect are specified, an ArgumentError is raised, as it is ambigious which should be used.