Using Path.join/1 to prevent double-slash issues #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Oct 26, 2023
| @@ -27,7 +27,7 @@ defmodule Phoenix.LiveDashboard.LayoutView do | |||
| Phoenix.VerifiedRoutes.unverified_path( | |||
| conn, | |||
| conn.private.phoenix_router, | |||
| "#{prefix}/#{asset}-#{hash}" | |||
| Path.join([prefix, "#{asset}-#{hash}"]) | |||
There was a problem hiding this comment.
This may use \ on Windows. We would probably need to check the prefix explicitly. Perhaps we should rather normalize __live_dashboard_prefix__ to return "" as the prefix when mounted on root?
cblavier
force-pushed
the
429-crash-on-root-path
branch
from
ee4437c
to
7abb707
Compare
josevalim
reviewed
Oct 26, 2023
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #429
I had a look in
page_builder_test.exsbut could not see any path-related tests, so I carefully didn't take any initiative ;-)