Update phx.gen.auth timestamps to match config #5794
Conversation
Follows up on phoenixframework#5586 that introduced the concept but missed a few places that set timestamps.
All generators seem to separate 'timestamps()' from the field definitions.
|
Need to test this better, perhaps the change of data type has unintented impact in other places. |
| @@ -8,7 +8,8 @@ defmodule <%= inspect schema.repo %>.Migrations.Create<%= Macro.camelize(schema. | |||
| <%= if schema.binary_id do %> add :id, :binary_id, primary_key: true | |||
| <% end %> <%= migration.column_definitions[:email] %> | |||
| add :hashed_password, :string, null: false | |||
| add :confirmed_at, :naive_datetime | |||
| add :confirmed_at, <%= inspect schema.timestamp_type %> | |||
There was a problem hiding this comment.
Would output one of :naive_datetime, :utc_datetime or :utc_datetime_usec.
I understand from the first note in https://hexdocs.pm/ecto/Ecto.Schema.html#module-primitive-types that those are valid values both in the schema definition and in the migration file.
When using database migrations provided by "Ecto SQL", you can pass your Ecto type as the column type. However, note the same Ecto type may support multiple database types. For example, all of :varchar, :text, :bytea, etc. translate to Ecto's :string. Similarly, Ecto's :decimal can be used for :numeric and other database types. For more information, see all migration types.
| <% :naive_datetime -> %>now = NaiveDateTime.utc_now() |> NaiveDateTime.truncate(:second) | ||
| <% :utc_datetime -> %>now = DateTime.utc_now() |> DateTime.truncate(:second) | ||
| <% :utc_datetime_usec -> %>now = DateTime.utc_now() |> DateTime.truncate(:microsecond) | ||
| <% end %>change(<%= schema.singular %>, confirmed_at: now) |
There was a problem hiding this comment.
Only handling the 3 documented values; formatted so as to not produce extraneous empty lines when rendered.
I noticed Elixir 1.15 supports the shorter DateTime.utc_now(:second), but I assume that since phx.new generates a mix.exs requiring Elixir 1.14 then there's no reason to break compatibility right now.
|
💚 💙 💜 💛 ❤️ |
Follows up on #5586 that introduced the concept but missed a few places that set timestamps.