Generate text data type as textarea #5784
Open
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhcarvalho
reviewed
May 14, 2024
| @@ -4,15 +4,16 @@ defmodule Mix.Tasks.Phx.Gen.Html do | |||
| @moduledoc """ | |||
| Generates controller with view, templates, schema and context for an HTML resource. | |||
|
|
|||
| mix phx.gen.html Accounts User users name:string age:integer | |||
| mix phx.gen.html Accounts User users name:string age:integer about:text | |||
There was a problem hiding this comment.
I find that using a textarea for text-type fields is a positive change, but the current docs changes do not help convey that distinction. It is probably not worth documenting anyway, as people are free and encouraged to change the generated code.
IMHO I'd keep the example mix call shorter as it was.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
mix phx.gen.html(andmix phx.gen.live) generate a single-line input field even if the user specifiestextas the data type. For example:mix phx.gen.html Blog Post posts title:string body:textwill generate the following form which is not what most users would expect.
In essence, there is no distinction between
stringandtexttypes as far as the generated HTML goes (though, the distinction exists in the generated migration file).This small patch allows for fields declared as
textto be generated as<textarea>.