Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong header level in changelog #5743

Merged

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Mar 6, 2024

Before:
image

After:
image

@SteffenDE
Copy link
Contributor

Hi there, thank you for the PR. I'm not sure if the first two headings shouldn't actually be left as is. Having the Introduction of verified routes and the phx.new revamp at the top of the navigation is probably fine.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
kianmeng and others added 2 commits March 10, 2024 00:29
Co-authored-by: Steffen Deusch <steffen@deusch.me>
Co-authored-by: Steffen Deusch <steffen@deusch.me>
@kianmeng kianmeng requested a review from SteffenDE March 9, 2024 16:29
@SteffenDE SteffenDE merged commit 6a8d8c2 into phoenixframework:main Mar 9, 2024
6 checks passed
@SteffenDE
Copy link
Contributor

Thank you! 🙌🏻

@kianmeng
Copy link
Contributor Author

kianmeng commented Mar 9, 2024

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants