Persist remote_ip during recycling of a conn (#5792)

phoenixframework · May 2, 2024 · 1820877 · 1820877
1 parent 5d3dc22
commit 1820877
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/phoenix/test/conn_test.ex b/lib/phoenix/test/conn_test.ex
@@ -499,6 +499,7 @@ defmodule Phoenix.ConnTest do
   def recycle(conn, headers \\ ~w(accept accept-language authorization)) do
     build_conn()
     |> Map.put(:host, conn.host)
+    |> Map.put(:remote_ip, conn.remote_ip)
     |> Plug.Test.recycle_cookies(conn)
     |> Plug.Test.put_peer_data(Plug.Conn.get_peer_data(conn))
     |> copy_headers(conn.req_headers, headers)

diff --git a/test/phoenix/test/conn_test.exs b/test/phoenix/test/conn_test.exs
@@ -221,6 +221,14 @@ defmodule Phoenix.Test.ConnTest do
       assert conn.host == "localhost"
     end
 
+    test "remote_ip is persisted" do
+      conn =
+        %Plug.Conn{build_conn(:get, "http://localhost/", nil) | remote_ip: {192, 168, 0, 1}}
+        |> recycle()
+
+      assert conn.remote_ip == {192, 168, 0, 1}
+    end
+
     test "cookies are persisted" do
       conn =
         build_conn()