Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show retrieval of data attributes #410

Merged
merged 1 commit into from Jul 11, 2022
Merged

Conversation

nathanl
Copy link
Contributor

@nathanl nathanl commented Jul 11, 2022

Initially I wondered whether the attribute should be passed as [data-name] to match the selector.

@philss philss merged commit a0eba43 into philss:master Jul 11, 2022
@philss
Copy link
Owner

philss commented Jul 11, 2022

@nathanl thank you! 💜

inoas added a commit to inoas/floki that referenced this pull request Aug 24, 2022
* master: (23 commits)
  Bump ex_doc from 0.28.4 to 0.28.5 (philss#416)
  Bump earmark from 1.4.26 to 1.4.27 (philss#415)
  Bump credo from 1.6.5 to 1.6.6 (philss#414)
  Bump dialyxir from 1.1.0 to 1.2.0 (philss#413)
  Bump credo from 1.6.4 to 1.6.5 (philss#412)
  Show retrieval of data attributes (philss#410)
  Release v0.33.1
  Improve the README.md file
  Fix warnings related to the tokenizer
  Change sponsors links - using GitHub Sponsors
  Release v0.33.0
  Added case insentive variation of fl-contains (philss#409)
  Bump html5ever from 0.13.0 to 0.13.1 (philss#407)
  Bump earmark from 1.4.25 to 1.4.26 (philss#406)
  Minor stuff I changed while reading (philss#404)
  Bump earmark from 1.4.24 to 1.4.25 (philss#403)
  Bump html5ever from 0.12.0 to 0.13.0 (philss#401)
  Bump ex_doc from 0.28.3 to 0.28.4 (philss#402)
  Remove case of 2 for tuple of :pi (philss#400)
  Bump earmark from 1.4.23 to 1.4.24 (philss#398)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants