Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Elixir 1.6 #300

Merged
merged 2 commits into from
Aug 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,17 @@ jobs:
strategy:
fail-fast: false
matrix:
elixir: ["1.9.4", "1.8.2", "1.7.4", "1.6.6"]
erlang: ["21.3.8"]
elixir: ["1.10.4", "1.9.4", "1.8.2", "1.7.4"]
erlang: ["21.3", "22.3", "23.0"]
ubuntu: ["bionic-20200219"]
parser: [fast_html, html5ever, mochiweb]
# nimble_pool, which fast_html depends on,
# does not work on Elixir 1.6.6
exclude:
- elixir: "1.6.6"
parser: fast_html
- elixir: "1.9.4"
erlang: "23.0"
- elixir: "1.8.2"
erlang: "23.0"
- elixir: "1.7.4"
erlang: "23.0"

steps:
- uses: actions/checkout@v1.0.0
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ concerns:
- Performance - It can be [up to 20 times slower than the alternatives](https://hexdocs.pm/fast_html/readme.html#benchmarks) on big HTML
documents.
- Correctness - in some cases `mochiweb_html` will produce different results
from what is specified in [HTML5 specification](https://html.spec.whatwg.org/)](https://html.spec.whatwg.org/).
from what is specified in [HTML5 specification](https://html.spec.whatwg.org/).
For example, a correct parser would parse `<title> <b> bold </b> text </title>`
as `{"title", [], [" <b> bold </b> text "]}` since content inside `<title>` is
to be [treated as plaintext](https://html.spec.whatwg.org/#the-title-element).
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ defmodule Floki.Mixfile do
name: "Floki",
version: @version,
description: @description,
elixir: "~> 1.6",
elixir: "~> 1.7",
package: package(),
deps: deps(),
aliases: aliases(),
Expand Down