Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ToggleStrategies::isEmpty #56

Merged
merged 2 commits into from Aug 27, 2022
Merged

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Aug 26, 2022

... so we do not need to hard-code a 0

@szepeviktor szepeviktor marked this pull request as ready for review August 26, 2022 07:18
@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kpicaza kpicaza self-assigned this Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #56 (397d009) into 1.0.x (ab91590) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##               1.0.x       #56   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       113       114    +1     
===========================================
  Files             25        25           
  Lines            279       281    +2     
===========================================
+ Hits             279       281    +2     
Impacted Files Coverage Δ
src/Read/Toggle.php 100.00% <100.00%> (ø)
src/Read/ToggleStrategies.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kpicaza kpicaza added the enhancement New feature or request label Aug 26, 2022
Copy link
Member

@kpicaza kpicaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice point @szepeviktor, it looks cleaner now 👏👏👏
Thanks for contributing 🎉🎉🎉

@kpicaza kpicaza merged commit 11fe3d2 into pheature-flags:1.0.x Aug 27, 2022
@szepeviktor szepeviktor deleted the patch-1 branch August 27, 2022 10:11
@szepeviktor
Copy link
Contributor Author

You're welcome.

@xserrat
Copy link
Contributor

xserrat commented Aug 27, 2022

Great contribution @szepeviktor! Thanks 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants