Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding style via PHP_CodeSniffer & assertion call #49

Merged

Conversation

peter279k
Copy link
Contributor

Changed log

  • To be consistency, using the $this to make all assertion methods call on PHP files.
  • Fixing coding style via PHP_CodeSniffer.

@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #49 (3920f3d) into 1.0.x (8089a80) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               1.0.x       #49   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       113       113           
===========================================
  Files             25        25           
  Lines            280       280           
===========================================
  Hits             280       280           
Impacted Files Coverage Δ
src/Exception/InvalidStrategyTypeGiven.php 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8089a80...3920f3d. Read the comment docs.

Copy link
Member

@kpicaza kpicaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @peter279k I want to add a little context linking to the Laminas forum https://discourse.laminas.dev/t/this-assert-vs-self-assert/448/3 and PHPUnit issue sebastianbergmann/phpunit#1914.

We are being inconsistent while we are using sometimes "self" and other times "$this". Thanks for fixing it 👏👏👏

@kpicaza kpicaza self-assigned this Jul 25, 2022
@kpicaza kpicaza added the enhancement New feature or request label Jul 25, 2022
@kpicaza kpicaza merged commit 3b82305 into pheature-flags:1.0.x Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants