Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#35] Add PHP 8.1 support #48

Merged
merged 1 commit into from Nov 20, 2021
Merged

[#35] Add PHP 8.1 support #48

merged 1 commit into from Nov 20, 2021

Conversation

xserrat
Copy link
Contributor

@xserrat xserrat commented Nov 20, 2021

Closes #35

@xserrat xserrat added the enhancement New feature or request label Nov 20, 2021
@xserrat xserrat self-assigned this Nov 20, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@xserrat xserrat added dependencies Pull requests that update a dependency file good first issue Good for newcomers Hacktoberfest HacktoberFest related issues labels Nov 20, 2021
@codecov
Copy link

codecov bot commented Nov 20, 2021 •
edited

Codecov Report

Merging #48 (98d7679) into 1.0.x (6d15866) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               1.0.x       #48   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       113       113           
===========================================
  Files             25        25           
  Lines            280       280           
===========================================
  Hits             280       280

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d15866...98d7679. Read the comment docs.

kpicaza
kpicaza approved these changes Nov 20, 2021
View reviewed changes
Copy link
Member

@kpicaza kpicaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kpicaza kpicaza merged commit 11ac4f0 into 1.0.x Nov 20, 2021
@kpicaza kpicaza deleted the issue#35-php81 branch November 20, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpicaza kpicaza kpicaza approved these changes

@pcs289 pcs289 Awaiting requested review from pcs289

Assignees

@xserrat xserrat

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[toggle-core] Add PHP 8.1 support
2 participants
@xserrat @kpicaza