Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#17] Add StrategyWasAdded event #44

Merged
merged 1 commit into from Nov 6, 2021
Merged

[#17] Add StrategyWasAdded event #44

merged 1 commit into from Nov 6, 2021

Conversation

kpicaza
Copy link
Member

@kpicaza kpicaza commented Nov 4, 2021

Closes #17

@kpicaza kpicaza added the enhancement New feature or request label Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021 •
edited

Codecov Report

Merging #44 (b2dff69) into 1.0.x (d3dc88f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##               1.0.x       #44   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       106       113    +7     
===========================================
  Files             24        25    +1     
  Lines            250       280   +30     
===========================================
+ Hits             250       280   +30
Impacted Files Coverage Δ
src/Write/Payload.php 100.00% <ø> (ø)
src/Write/Segment.php 100.00% <ø> (ø)
src/Write/Strategy.php 100.00% <ø> (ø)
src/Write/Event/StrategyWasAdded.php 100.00% <100.00%> (ø)
src/Write/Feature.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3dc88f...b2dff69. Read the comment docs.

xserrat
xserrat approved these changes Nov 6, 2021
View reviewed changes
Copy link
Contributor

@xserrat xserrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sonarcloud
Copy link

sonarcloud bot commented Nov 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kpicaza kpicaza merged commit 25e9adf into 1.0.x Nov 6, 2021
@kpicaza kpicaza deleted the issue#17 branch November 6, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xserrat xserrat xserrat approved these changes

@pcs289 pcs289 Awaiting requested review from pcs289

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create AnStrategyWasAdded event and dispatch it inside Feature Class
2 participants
@kpicaza @xserrat