Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#28] Create FeatureWasRemoved event and record it inside Feature Class #29

Merged
merged 2 commits into from Oct 6, 2021
Merged

[#28] Create FeatureWasRemoved event and record it inside Feature Class #29

merged 2 commits into from Oct 6, 2021

Conversation

xserrat
Copy link
Contributor

@xserrat xserrat commented Oct 6, 2021 •
edited

Closes #28

It'll need a new tag 0.1.3 to update other dependant packages.

@xserrat xserrat added enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues labels Oct 6, 2021
@xserrat xserrat requested review from kpicaza and pcs289 October 6, 2021 19:09
@xserrat xserrat self-assigned this Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021 •
edited

Codecov Report

Merging #29 (f49c481) into 1.0.x (f88494f) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              1.0.x      #29      +/-   ##
============================================
+ Coverage     95.67%   95.89%   +0.21%     
- Complexity       86       91       +5     
============================================
  Files            21       22       +1     
  Lines           208      219      +11     
============================================
+ Hits            199      210      +11     
  Misses            9        9
Impacted Files Coverage Δ
src/Write/Event/FeatureWasRemoved.php 100.00% <100.00%> (ø)
src/Write/Feature.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f88494f...f49c481. Read the comment docs.

kpicaza
kpicaza approved these changes Oct 6, 2021
View reviewed changes
Copy link
Member

@kpicaza kpicaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@xserrat xserrat merged commit 633ff8b into 1.0.x Oct 6, 2021
@xserrat xserrat deleted the issue#28-remove-event branch October 6, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpicaza kpicaza kpicaza approved these changes

@pcs289 pcs289 Awaiting requested review from pcs289

Assignees

@xserrat xserrat

Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create FeatureWasRemoved event and record it inside Feature Class
2 participants
@xserrat @kpicaza