Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature was enabled event #27

Merged
merged 1 commit into from Oct 5, 2021
Merged

Add feature was enabled event #27

merged 1 commit into from Oct 5, 2021

Conversation

vblinden
Copy link
Contributor

@vblinden vblinden commented Oct 4, 2021

This will fix #19

@codecov
Copy link

codecov bot commented Oct 4, 2021 •
edited

Codecov Report

Merging #27 (2e73657) into 1.0.x (41da1a9) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              1.0.x      #27      +/-   ##
============================================
+ Coverage     95.45%   95.67%   +0.21%     
- Complexity       82       86       +4     
============================================
  Files            20       21       +1     
  Lines           198      208      +10     
============================================
+ Hits            189      199      +10     
  Misses            9        9
Impacted Files Coverage Δ
src/Write/Event/FeatureWasEnabled.php 100.00% <100.00%> (ø)
src/Write/Feature.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41da1a9...2e73657. Read the comment docs.

@kpicaza kpicaza requested review from kpicaza and pcs289 October 4, 2021 15:18
kpicaza
kpicaza approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@kpicaza kpicaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for participating;-D. 👏👏👏 Nice done!

@kpicaza kpicaza added enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues labels Oct 4, 2021
@kpicaza kpicaza requested a review from xserrat October 4, 2021 16:21
@kpicaza kpicaza self-assigned this Oct 5, 2021
@kpicaza
Copy link
Member

kpicaza commented Oct 5, 2021

Good job, shipping 🚢🚢🚢

@kpicaza kpicaza merged commit f88494f into pheature-flags:1.0.x Oct 5, 2021
@vblinden vblinden deleted the feature-enabled branch October 6, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpicaza kpicaza kpicaza approved these changes

@pcs289 pcs289 Awaiting requested review from pcs289

@xserrat xserrat Awaiting requested review from xserrat

Assignees

@kpicaza kpicaza

Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create FeatureWasEnabled event and dispatch it inside Feature Class
2 participants
@vblinden @kpicaza