Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature was disabled event #25

Merged
merged 2 commits into from Oct 3, 2021
Merged

Add feature was disabled event #25

merged 2 commits into from Oct 3, 2021

Conversation

vblinden
Copy link
Contributor

@vblinden vblinden commented Oct 3, 2021

Hello,

This pull request fixes issue #20.

@kpicaza kpicaza requested a review from pcs289 October 3, 2021 14:27
@xserrat xserrat added enhancement New feature or request Hacktoberfest HacktoberFest related issues good first issue Good for newcomers labels Oct 3, 2021
@xserrat xserrat linked an issue Oct 3, 2021 that may be closed by this pull request
Create FeatureWasDisabled event and dispatch it inside Feature Class #20
Closed
pcs289
pcs289 approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@pcs289 pcs289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codecov
Copy link

codecov bot commented Oct 3, 2021 •
edited

Codecov Report

Merging #25 (205e9ca) into 1.0.x (5f92f6e) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              1.0.x      #25      +/-   ##
============================================
+ Coverage     95.21%   95.45%   +0.24%     
- Complexity       78       82       +4     
============================================
  Files            19       20       +1     
  Lines           188      198      +10     
============================================
+ Hits            179      189      +10     
  Misses            9        9
Impacted Files Coverage Δ
src/Write/Event/FeatureWasDisabled.php 100.00% <100.00%> (ø)
src/Write/Feature.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f92f6e...205e9ca. Read the comment docs.

@pcs289 pcs289 requested a review from kpicaza October 3, 2021 14:38
kpicaza
kpicaza approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@kpicaza kpicaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing 👏👏👏 Nice work!

@kpicaza kpicaza merged commit 41da1a9 into pheature-flags:1.0.x Oct 3, 2021
@vblinden vblinden deleted the feature-disabled branch October 3, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpicaza kpicaza kpicaza approved these changes

@pcs289 pcs289 pcs289 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create FeatureWasDisabled event and dispatch it inside Feature Class
4 participants
@vblinden @kpicaza @pcs289 @xserrat