Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#15] add ability to collect events in Feature write model #21

Merged
merged 1 commit into from Oct 2, 2021

Conversation

kpicaza
Copy link
Member

@kpicaza kpicaza commented Oct 2, 2021

Closes #15 and unlock the other tasks in the epic ;-D

@kpicaza kpicaza added enhancement New feature or request Hacktoberfest HacktoberFest related issues labels Oct 2, 2021
@kpicaza kpicaza requested review from pcs289 and xserrat October 2, 2021 12:00
@kpicaza kpicaza self-assigned this Oct 2, 2021
@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #21 (7a40775) into 1.0.x (6eefd0c) will decrease coverage by 2.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              1.0.x      #21      +/-   ##
============================================
- Coverage     93.06%   90.96%   -2.11%     
- Complexity       73       74       +1     
============================================
  Files            18       18              
  Lines           173      177       +4     
============================================
  Hits            161      161              
- Misses           12       16       +4     
Impacted Files Coverage Δ
src/Write/Feature.php 75.86% <0.00%> (-12.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eefd0c...7a40775. Read the comment docs.

@kpicaza kpicaza added the hacktoberfest-accepted HacktoberFest accepted pull requests label Oct 2, 2021
Copy link
Contributor

@xserrat xserrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kpicaza kpicaza merged commit 55c9c39 into 1.0.x Oct 2, 2021
@kpicaza kpicaza deleted the issue#15 branch October 2, 2021 15:52
@kpicaza kpicaza restored the issue#15 branch October 2, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest HacktoberFest related issues hacktoberfest-accepted HacktoberFest accepted pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to save events in the write model Feature class
2 participants