Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create FeatureWasRemoved event and record it inside Feature Class #28

Closed
xserrat opened this issue Oct 6, 2021 · 0 comments · Fixed by #29
Closed

Create FeatureWasRemoved event and record it inside Feature Class #28

xserrat opened this issue Oct 6, 2021 · 0 comments · Fixed by #29
Assignees
@xserrat
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues

Comments

@xserrat
Copy link
Contributor

xserrat commented Oct 6, 2021

Epic: pheature-flags/pheature-flags#297
Depends on: #15

We want to save Pheature\Core\Toggle\Write\Event\FeatureWasRemoved event on the Pheature\Core\Toggle\Write\Featureclass when theFeature` needs to be removed.

It's a work in progress but the first iteration is the creation of a new method Feature::remove that should save the event.
@xserrat xserrat added enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues labels Oct 6, 2021
@xserrat xserrat self-assigned this Oct 6, 2021
xserrat added a commit that referenced this issue Oct 6, 2021
@xserrat
[#28] Simplify the Feature creation in different states for FeatureTest
43928fa
xserrat added a commit that referenced this issue Oct 6, 2021
@xserrat
[#28] Create FeatureWasRemoved event and record it inside Feature Class
f49c481
@xserrat xserrat mentioned this issue Oct 6, 2021
Merged
xserrat added a commit that referenced this issue Oct 6, 2021
@xserrat
[#28] Simplify the Feature creation in different states for FeatureTest
cd9e384
xserrat added a commit that referenced this issue Oct 6, 2021
@xserrat
[#28] Create FeatureWasRemoved event and record it inside Feature Class
633ff8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xserrat xserrat

Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest HacktoberFest related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#28] Create FeatureWasRemoved event and record it inside Feature Class pheature-flags/toggle-core
1 participant
@xserrat