Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint-setup: Adds logic to create simplified eslintrc.js file. #942

Open
wants to merge 5 commits into
base: eleven
Choose a base branch
from
Open

eslint-setup: Adds logic to create simplified eslintrc.js file. #942

wants to merge 5 commits into from
+42 −5

Conversation

LeeMellon
Copy link

Pull Request

Adds logic to create simplified eslintrc.js file.
nukeme____dev_nukeme__-______eslintrc_js_and_iangoodrich_elfayoumi____dev_particle

mealeyst
mealeyst reviewed Aug 18, 2020
View reviewed changes
Copy link

@mealeyst mealeyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, just a minor note on spacing consistancy

packages/generator-particle-base/src/generators/app/index.ts Outdated Show resolved Hide resolved
@LeeMellon @mealeyst
Update packages/generator-particle-base/src/generators/app/index.ts
e48dc7f 
Co-authored-by: Shawn Mealey <mealeyst@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrederickEngelhardt FrederickEngelhardt Awaiting requested review from FrederickEngelhardt

@jryanconklin jryanconklin Awaiting requested review from jryanconklin

@mealeyst mealeyst Awaiting requested review from mealeyst

Assignees
No one assigned
Labels
V11-Alpha
Projects
v11.0
  
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LeeMellon @mealeyst @IMGoodrich