-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Patternlab Generator #908
base: eleven
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,49 @@ | |||
import Generator from 'yeoman-generator' | |||
import fs from 'fs' | |||
import _ from 'lodash' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the lodash/merge npm package. Check the particle-base generator for that dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"declaration": true, | ||
"outDir": "lib", | ||
"rootDir": "./src", | ||
"strict": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to bring strict
to the base of the project. This may require additional fixes.
I did run this in eleven
and found no errors. So we're probably good to go with moving this to the base tsconfig.json in the root of the project.
'pl:serve': | ||
'patternlab serve --config ./node_modules/@pattern-lab/starterkit-twig-demo/patternlab-config.json', | ||
'pl:version': 'patternlab --version', | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Adding the Patternlab Yeoman Generator.
NOTE: This is a WIP PR, please do not merge