WIP: fix: revert batch executions that silently accept select statements #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
=========================================
Coverage 65.94% 65.94%
- Complexity 3562 3563 +1
=========================================
Files 166 166
Lines 15244 15244
Branches 2465 2465
=========================================
Hits 10053 10053
Misses 4022 4022
Partials 1169 1169 |
vlsi
requested changes
Oct 7, 2017
| updateCounts[2] == 1 || updateCounts[2] == Statement.SUCCESS_NO_INFO); | ||
| try { | ||
| stmt.executeBatch(); | ||
| Assert.fail("Should raise a BatchUpdateException because of the SELECT"); |
There was a problem hiding this comment.
Please add explicit reference that clarifies why "select should raise BatchUpdateException"
| int[] updateCounts = e.getUpdateCounts(); | ||
| // There are 3 batches | ||
| Assert.assertEquals(3, updateCounts.length); | ||
| Assert.assertEquals(Statement.EXECUTE_FAILED, updateCounts[0]); |
There was a problem hiding this comment.
All the contents of resulting array should be verified, not just the first element
| Assert.assertEquals(3, updateCounts.length); | ||
| Assert.assertEquals(Statement.EXECUTE_FAILED, updateCounts[0]); | ||
| } catch (SQLException e) { | ||
| Assert.fail("Should throw a BatchUpdateException instead of a generic SQLException: " + e); |
There was a problem hiding this comment.
Please avoid +e pattern, and add reference to the spec.
There was a problem hiding this comment.
Sure, this was just a quick copy/revert of the method. I need to verify the correct behavior.
jorsol
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #970