Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rework OSGi bundle activator so it does not rely on exception message to check DataSourceFactory presence #507

Merged
merged 1 commit into from May 9, 2021
Merged

fix: rework OSGi bundle activator so it does not rely on exception message to check DataSourceFactory presence #507

merged 1 commit into from May 9, 2021

Conversation

vlsi
Copy link
Member

@vlsi vlsi commented Feb 7, 2016 •
edited

fixes #2133

@vlsi vlsi mentioned this pull request Feb 7, 2016
Closed
@vlsi vlsi force-pushed the osgi_tests branch 3 times, most recently from 7942a25 to 7c3b64b Compare February 8, 2016 21:25
@vlsi vlsi mentioned this pull request May 14, 2016
Closed
@vlsi vlsi force-pushed the osgi_tests branch 8 times, most recently from 7632e21 to d143a4f Compare May 14, 2016 19:56
@codecov-io
Copy link

codecov-io commented May 14, 2016 •
edited

Current coverage is 56.77%

Merging #507 into master will decrease coverage by 13.71%

  1. 5 files (not in diff) in ...va/org/postgresql/xa were modified. more
    • Misses +154
    • Hits -154
  2. 20 files (not in diff) in .../org/postgresql/util were modified. more
    • Misses +126
    • Partials +50
    • Hits -176
  3. 2 files (not in diff) in .../org/postgresql/sspi were modified. more
    • Misses +14
    • Hits -14
  4. 2 files (not in diff) in ...postgresql/ssl/jdbc4 were modified. more
    • Misses +39
    • Hits -39
  5. 2 files (not in diff) in ...a/org/postgresql/ssl were modified. more
    • Misses +20
    • Hits -20
  6. 2 files (not in diff) in .../org/postgresql/osgi were modified. more
    • Misses +3
    • Partials +13
    • Hits -16
  7. 4 files (not in diff) in ...stgresql/largeobject were modified. more
    • Misses +5
    • Partials +16
    • Hits -21
  8. 20 files (not in diff) in .../org/postgresql/jdbc were modified. more
    • Misses +231
    • Partials +643
    • Hits -874
  9. 3 files (not in diff) in ...stgresql/hostchooser were modified. more
    • Misses +13
    • Partials +10
    • Hits -23
  10. 3 files (not in diff) in ...a/org/postgresql/gss were modified. more
    • Misses +27
    • Hits -27
@@             master       #507   diff @@
==========================================
  Files           146        146           
  Lines         15495      15495           
  Methods           0          0           
  Messages          0          0           
  Branches       3055       3055           
==========================================
- Hits          10921       8796   -2125   
- Misses         4574       5527    +953   
- Partials          0       1172   +1172

Powered by Codecov. Last updated by 18ca8f2...4968b5c

@vlsi vlsi force-pushed the osgi_tests branch 7 times, most recently from 31131e5 to 60703bd Compare May 15, 2016 10:58
@vlsi vlsi force-pushed the master branch 3 times, most recently from d1c9cd8 to 154c463 Compare September 17, 2016 11:22
@vlsi vlsi force-pushed the master branch 2 times, most recently from c8cebf6 to f52bf7f Compare October 29, 2016 19:46
@vlsi vlsi mentioned this pull request Dec 10, 2017
Closed
@vlsi vlsi mentioned this pull request Sep 3, 2019
Merged
6 tasks
@davecramer
Copy link
Member

@vlsi can we close this?

@vlsi vlsi force-pushed the master branch 2 times, most recently from c25d807 to adcb194 Compare March 7, 2020 20:41
@vlsi vlsi mentioned this pull request Jul 3, 2020
Merged
@vlsi vlsi force-pushed the master branch 2 times, most recently from 4c39f96 to 866c6a9 Compare August 21, 2020 18:18
@vlsi vlsi mentioned this pull request May 4, 2021
Closed
@davecramer
Copy link
Member

I'm curious how this runs. Where does it get the properties from ?

@vlsi
Copy link
Member Author

vlsi commented May 8, 2021

@davecramer , it works on my machine, and I guess it should be able to reproduce DataSourceFactory failure on IBM JVM.

@vlsi vlsi changed the title test: OSGi tests fix: rework OSGi bundle activator so it does not rely on exception message to check DataSourceFactory presence May 8, 2021
@vlsi vlsi mentioned this pull request May 8, 2021
Closed
@vlsi vlsi mentioned this pull request May 8, 2021
Closed
@vlsi vlsi force-pushed the osgi_tests branch 2 times, most recently from 677c1fa to b40b28c Compare May 9, 2021 18:23
@vlsi vlsi merged commit c82df0e into pgjdbc:master May 9, 2021
@davecramer
Copy link
Member

nice, thanks for taking care of this!

@vlsi vlsi mentioned this pull request Jun 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 11, 2021
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Jul 7, 2021
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Oct 19, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Nov 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PGBundleActivator class issues on OpenJ9
3 participants
@vlsi @codecov-io @davecramer