Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test both binaryMode=true,false when creating connections in DatabaseMetaDataTest #3231

Merged
merged 1 commit into from May 10, 2024
Merged

test: test both binaryMode=true,false when creating connections in DatabaseMetaDataTest #3231

merged 1 commit into from May 10, 2024
+161 −64

Conversation

vlsi
Copy link
Member

@vlsi vlsi commented Apr 24, 2024

Fixes #3229

It looks like jdbc2.DatabaseMetaDataTest was the only impacted test.

@vlsi vlsi changed the title test: sue binaryMode when creating connections in DatabaseMetaDataTest test: test both binaryMode=true,false when creating connections in DatabaseMetaDataTest Apr 24, 2024
@vlsi vlsi force-pushed the beforeeach_parameters branch 4 times, most recently from eb93cea to 761d622 Compare April 24, 2024 16:04
@davecramer
Copy link
Member

I didn't think the source distribution did tests ? Either way strange failures

@vlsi
Copy link
Member Author

vlsi commented May 10, 2024

The source distribution was failing as it missed junit.jupiter.extensions.autodetection.enabled=true in the pom.

@vlsi vlsi force-pushed the beforeeach_parameters branch 5 times, most recently from dc863f5 to 7a4dbd9 Compare May 10, 2024 20:23
@vlsi vlsi merged commit 4956902 into pgjdbc:master May 10, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DatabaseMetaDataTest does not test binary mode
2 participants
@vlsi @davecramer