Add module-info support

[Sineaggi]

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

1. Does your submission pass tests?
2. Does ./gradlew styleCheck pass ?
3. Have you added your new test classes to an existing test suite in alphabetical order?

Fixes #1979, #2657

• Adds module-info.java file.
• Adds new black-box test suite to verify the jar we created is modular.
• Bumped a few dependencies to get updated automatic-module-names or modular jars (waffle, osgi).
• Didn't upgrade scram version, as it's shaded in the released jar.
• Added a new sourceSet that compiled the module-info.java file.

[davecramer]

Unfortunately we need to release java 8.
Until that changes I don't see how this works ?

[vlsi]

Is this change required for module?

[Sineaggi]

As-is, the dependencies don't have automatic module names, which causes compilation failure. The versions I bumped to do.

[Sineaggi]

I could downgrade and remove the static requirements

  requires static com.sun.jna;
  requires static com.sun.jna.platform;
  requires static waffle.jna;
  requires static org.osgi.service.jdbc;
  requires static osgi.core;

from the module, but then if those classes (like PGBundleActivator) are loaded you'd see an exception

Exception in thread "main" java.lang.IllegalAccessError: superinterface check failed: class org.postgresql.osgi.PGBundleActivator (in module org.postgresql.jdbc) cannot access class org.osgi.framework.BundleActivator (in unnamed module @0x4fca772d) because module org.postgresql.jdbc does not read unnamed module @0x4fca772d

[Sineaggi]

We could leave the requirements out and just mark waffle and osgi as non-required under modules. Not sure how that would affect future modular versions of waffle or osgi.

[vlsi]

Should Automatic-Module-Name be removed if we move to non-automatic modules?

[Sineaggi]

Ah yes. Actually, I was going to make a comment about this block. Doesn't this configure every jar, including javadoc and sources? Perhaps these should only be made in the main and shadow jar?

[vlsi]

I think we might need to declare more packages for the exports

[Sineaggi]

We could mark the whole module as open, or try to be more selective. Is there a list of packages that should be exported?

[Sineaggi]

@davecramer

Unfortunately we need to release java 8. Until that changes I don't see how this works ?

This created a multi-release jar meaning the main jar targets 8+, and the module-info.class file is only visible to java versions 11+.