New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add "ANCESTOR TABLE" table type(#3194) #3215
base: master
Are you sure you want to change the base?
Conversation
This will require documentation and tests |
Can you give some examples of documentation and test code? |
We should test for ANCESTOR TABLE and PARTITIONED TABLES As for docs since both of these are not standard we should add this to https://github.com/pgjdbc/pgjdbc/blob/master/docs/content/documentation/use.md somewhere |
Ok, thank you , i will add these. |
I don't think we test for |
@davecramer Hi, I add some test code reference to the #1708 ,but I didn't find any document about "PARTITIONED TABLE", how |
Looks like we already have the test code for pgjdbc/pgjdbc/src/test/java/org/postgresql/test/jdbc2/DatabaseMetaDataTest.java Line 1545 in 4e710d5
|
@davecramer hi,do I need to do anything else? |
if (TestUtil.haveMinimumServerVersion(con, ServerVersion.v11)) { | ||
Statement stmt = null; | ||
try { | ||
stmt = con.createStatement(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Us try with resources, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I need to delete the test table in the finally code block, is it necessary to use try-with-resource
here?
Yes, please add docs here https://github.com/pgjdbc/pgjdbc/blob/master/docs/content/documentation/use.md |
I will and the following document at the bottom of this document. What do you think?
|
All Submissions:
New Feature Submissions:
./gradlew styleCheck
pass ?