Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated SimpleParameterList to fix the byte-array - Addresses a bug that caused syntax errors when executing SELECT statements with parameterized byte arrays #3181

Closed
wants to merge 2 commits into from
Closed

updated SimpleParameterList to fix the byte-array - Addresses a bug that caused syntax errors when executing SELECT statements with parameterized byte arrays #3181

wants to merge 2 commits into from

Conversation

siddeshas07
Copy link

@siddeshas07 siddeshas07 commented Mar 26, 2024 •
edited

All Submissions:

This Pr Addresses a bug that caused syntax errors when executing SELECT statements with parameterized byte arrays, specifically in cases like SELECT FROM bytea_test WHERE b = ? in #3169. #3169

  • [ Y] Have you followed the guidelines in our Contributing document?
  • [ Y] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. [ Y] Does your submission pass tests?
  2. [ Y] Does ./gradlew styleCheck pass ?
  3. [ Y] Have you added your new test classes to an existing test suite in alphabetical order?

Changes to Existing Features:

  • [ N] Does this break existing behaviour? If so please explain.
  • [ Y] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ N] Have you written new tests for your core changes, as applicable?
  • [ Y] Have you successfully run tests with your changes locally?

@siddeshas07 siddeshas07 marked this pull request as draft March 26, 2024 09:18
@siddeshas07 siddeshas07 marked this pull request as ready for review March 26, 2024 09:18
@siddeshas07 siddeshas07 changed the title updated SimpleParameterList to fix the byte-array - Addresses a bug that caused syntax errors when executing SELECT statements with parameterized byte arrays, specifically in cases like SELECT FROM bytea_test WHERE b = ? updated SimpleParameterList to fix the byte-array - Addresses a bug that caused syntax errors when executing SELECT statements with parameterized byte arrays Mar 26, 2024
davecramer
davecramer reviewed Mar 26, 2024
View reviewed changes
pgjdbc/src/main/java/org/postgresql/core/v3/SimpleParameterList.java Outdated

if (value instanceof byte[]) {
byte[] byteArray = (byte[]) value;
String hexString = new BigInteger(1, byteArray).toString(16);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure this isn't going to work

@vlsi
Copy link
Member

vlsi commented May 12, 2024

Superseded with #3243

@vlsi vlsi closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davecramer davecramer davecramer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siddeshas07 @vlsi @davecramer