refactor: merge PgPreparedStatement#setBinaryStream int and long methods #3165
Conversation
| checkClosed(); | ||
|
|
||
| if (value == null) { | ||
| setNull(parameterIndex, Oid.BYTEA); |
There was a problem hiding this comment.
this was setNull(parameterIndex, Types.VARBINARY); in the first method
There was a problem hiding this comment.
I see, but in method setNull(int parameterIndex, int sqlType), “Types.VARBINARY” and “Oid.BYTEA” are equivalent.
case Types.BINARY:
case Types.VARBINARY:
case Types.LONGVARBINARY:
oid = Oid.BYTEA;
break;There was a problem hiding this comment.
Good catch, I'll withdraw my criticism
There was a problem hiding this comment.
glad to help with the improvement of PG
There was a problem hiding this comment.
This should be a constant from java.sql.Types, not an Oid.
So Oid.BYTEA is not valid here, and it causes tests to fail.
There was a problem hiding this comment.
Thank you for the reminder. I made a mistake.
I confused PrepareStatement.setNull and preparedParameters.setNull, PrepareStatement.setNull should never use oid as a parameter.
vlsi
changed the title
The content of the two setBinaryStream methods is almost identical. Combine them to reduce code complexity