Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mismatched types for invokeExact. Have to tell invokeExact what type we are expecting #2589

Merged
merged 1 commit into from Aug 15, 2022

Conversation

davecramer
Copy link
Member

fixes issue #2588

@davecramer
Copy link
Member Author

Hmmm AccessControlContext is deprecated in 17 so javadoc fails.

@vlsi
Copy link
Member

vlsi commented Aug 15, 2022

The workaround it is to remove import statement and replace it with fully-qualified class name. Then SuppressWarnings annotation on method would allow suppressing the warning.

However, if AccessControlContext is removed, we won't be able to compile the code.

Should we remove MethodHandle and replace it with regular reflection then?

@davecramer
Copy link
Member Author

I was about to push exactly the above fix to get this to work.
So I'll push this and then release so the issue can be resolved
We are going to have to rewrite all of this eventually when they remove it.

@Rob4001
Copy link

Rob4001 commented Aug 15, 2022

Sorry, Been trying to get this working within constraints of work policies...
The original change does seem to get past the original issue but the SUBJECT_DO_AS reflection is fetching the wrong method signature, still working on it but I think it needs to be PriviledgedAction instead of PriviledgedExceptionAction

@Rob4001
Copy link

Rob4001 commented Aug 15, 2022

Also noticed that "subjectCallAs" is never set

@vlsi
Copy link
Member

vlsi commented Aug 15, 2022

Let's resort to a regular reflection then. Apparently, MethodHandle-related code seems too brittle :-/

@davecramer
Copy link
Member Author

OK, let me undo that merge then

@davecramer
Copy link
Member Author

Since I have merged code I can't revert this easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants