fix: make sure we select array_in from pg_catalog to avoid duplicate array_in functions fixes Issue #2548 #2552
Conversation
…array_in functions fixes #Issue 2548
| @@ -219,7 +219,7 @@ private String getSQLTypeQuery(boolean typoidParam) { | |||
| // (keeping old behaviour of finding types, that should not be found without correct search | |||
| // path) | |||
| StringBuilder sql = new StringBuilder(); | |||
| sql.append("SELECT typinput='array_in'::regproc as is_array, typtype, typname, pg_type.oid "); | |||
| sql.append("SELECT typinput='pg_catalog.array_in'::regproc as is_array, typtype, typname, pg_type.oid "); | |||
There was a problem hiding this comment.
@davecramer , do you know if pg_type.typarray != 0 answers that better?
typarray was added in 8.3: https://www.postgresql.org/docs/8.3/catalog-pg-type.html while we support 8.4+
There was a problem hiding this comment.
If typarray is not 0 then it identifies another row in pg_type, which is the "true" array type having this type as element. So it only says that there is an array type for this type.
There was a problem hiding this comment.
indeed.
Then PG 14 might bring new joy with its typsubscript and typelem (https://www.postgresql.org/docs/14/catalog-pg-type.html).
However, it looks like typelem has a broader meaning than just an array.
|
My vague recollection is that it didn't answer everything. I'd like to be proven wrong. |
davecramer
changed the title
No description provided.