perf: enable tcpNoDelay by default #2495
Merged
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2341 the option to
configure tcpNoDelay was added, with a default value of false.
The previous value of this setting was true, as set in
PGStream.changeSocket(Socket) with the following code:
changeSocket()
is called from thePGStream
constructor, which iscalled in
ConnectionFactoryImpl
, and then later we overwrite the valuewith the one from the properties.
We had a performance issue when upgrading from 42.2.24 to 42.3.3, and we suspected the
issue in 42.3.2 and confirmed that by passing the property
tcpNoDelay=true
to the driver,the performance issue was fixed.
All Submissions:
Changes to Existing Features:
no breaking change
no need