Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improv doc around binary decoding of numeric data #2331

Merged
merged 1 commit into from Nov 1, 2021

Conversation

bokken
Copy link
Member

@bokken bokken commented Oct 29, 2021

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Does ./gradlew autostyleCheck checkstyleAll pass ?
  3. Have you added your new test classes to an existing test suite in alphabetical order?

Changes to Existing Features:

  • Does this break existing behaviour? If so please explain.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@bokken
Copy link
Member Author

bokken commented Nov 1, 2021

@davecramer, there is no "algorithm" I copied for decoding the binary representation of numeric.
Do the inline comments added here help explain how/why the data is being interpreted/processed?

@davecramer
Copy link
Member

Yes, much better. Thanks, please merge this.

@bokken bokken merged commit a29767e into pgjdbc:master Nov 1, 2021
@bokken bokken deleted the numeric_doc branch November 1, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants