fix: resultsets should be updateable if there is a unique constraint on the table fixes issue #2196 #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on the table fixes issue pgjdbc#2196
davecramer
added a commit
to davecramer/pgjdbc
that referenced
this pull request
Jul 12, 2021
…2199 made some incorrect assumptions about unique keys that were incorrect. When we have both primary keys and unique keys only use the Primary keys for updating the row.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a protected method inside PgDatabaseMetaData to extend the search for primary keys to include unique keys as well
Added tests