Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure the table have defined primary keys when using updateable resultset #2101

Merged
merged 3 commits into from Mar 22, 2021

Conversation

Fzhlib
Copy link
Contributor

@Fzhlib Fzhlib commented Mar 15, 2021

Fix for #1975

  • fix: make sure the table have defined primary keys when using updateable resultset
  • test: add test for updateable resultset without primary key

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@Fzhlib
Copy link
Contributor Author

Fzhlib commented Mar 18, 2021

Hi @davecramer, Is there anything else i should do?

@davecramer davecramer merged commit 66b1e02 into pgjdbc:master Mar 22, 2021
davecramer pushed a commit to davecramer/pgjdbc that referenced this pull request Mar 22, 2021
…ble resultset (pgjdbc#2101)

* fix: make sure the table have defined primary keys when using updateable resultset

* test: add test for updateable resultset without primary key

Co-authored-by: System Administrator <root@192.168.0.15>
Co-authored-by: Fe <fe@192.168.0.15>
@Fzhlib Fzhlib deleted the fix_isUpdateable branch March 23, 2021 09:08
davecramer added a commit that referenced this pull request Apr 26, 2021
…ble resultset (#2101) (#2106)

* fix: make sure the table have defined primary keys when using updateable resultset

* test: add test for updateable resultset without primary key

Co-authored-by: Feng zhihao <Fzhlib@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants