fix: PgDatabaseMetaData.getTables() should return UPPERCASE column names as per spec #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should we cherry pick this into 42.2 ? I think so. |
davecramer
changed the title
davecramer
changed the title
davecramer
added a commit
to davecramer/pgjdbc
that referenced
this pull request
Mar 22, 2021
pgjdbc#2092) * fix: PgDatabaseMetaData should return UPPERCASE column names as per spec, fixes pgjdbc#830 * fix javadoc errors
davecramer
added a commit
to davecramer/pgjdbc
that referenced
this pull request
Mar 22, 2021
…rn UPPERCASE column names as per spec
|
@davecramer we are on 42.2.9 and didn't realize the change. Exactly what we need. Before we upgrade, can you confirm this will return uppercase for tables, columns but also indices (and columns thereof) ? |
|
getColumns returns upper case field names. getIndexInfo does not, however getString("INDEX_NAME") will work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only questionable thing is exposing this method publicly and removing final on Field.columnName