fix: "Required class information missing" when old org.jboss:jandex parses pgjdbc classes #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vlsi thx! it failed one test, is that an issue ? |
bokken
reviewed
Jan 3, 2021
vlsi
changed the title
vlsi
force-pushed
the
wa_type_annotations
branch
from
925d4a6
to
69da2ba
Compare
vlsi
force-pushed
the
wa_type_annotations
branch
from
69da2ba
to
3027175
Compare
vlsi
force-pushed
the
wa_type_annotations
branch
from
3027175
to
244071b
Compare
vlsi
force-pushed
the
wa_type_annotations
branch
from
244071b
to
e2665ac
Compare
vlsi
force-pushed
the
wa_type_annotations
branch
from
e2665ac
to
93b2713
Compare
bokken
approved these changes
Jan 6, 2021
vlsi
force-pushed
the
wa_type_annotations
branch
from
93b2713
to
954fc2c
Compare
vlsi
force-pushed
the
wa_type_annotations
branch
from
954fc2c
to
c50b63b
Compare
vlsi
force-pushed
the
wa_type_annotations
branch
from
c50b63b
to
e2a7c6b
Compare
vlsi
force-pushed
the
wa_type_annotations
branch
4 times, most recently
from
0d02ac1
to
a18b9dc
Compare
|
Ok, it looks like this is ready provided CI completes successfully. |
vlsi
force-pushed
the
wa_type_annotations
branch
2 times, most recently
from
74efc79
to
9bdf402
Compare
…arses pgjdbc classes (PR pgjdbc#2010)
vlsi
force-pushed
the
wa_type_annotations
branch
from
9bdf402
to
2df6c97
Compare
vlsi
referenced
this pull request
in ben-manes/caffeine
Jan 18, 2021
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2008
Note:
@NonNullis a default mode, so the annotations were not really needed.TL;DR:
jandexfails to parseT extends @AnyAnnotaion SomeInterfacebecause it is compiled toT::LSomeInterface;signature attribute in the class file.If an annotation is really needed, then something like
T extends @AnyAnnotation Object & @AnyAnnotation SomeInterfacecould workaround the issue in theory because it would be compiled toT:Ljava/lang/Object;:LSomeInterface;.