Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: introduce tuple abstraction (rebased) #1701

Merged
merged 4 commits into from Feb 10, 2020
Merged

refactor: introduce tuple abstraction (rebased) #1701

merged 4 commits into from Feb 10, 2020

Conversation

paplorinc
Copy link
Contributor

@paplorinc paplorinc commented Feb 10, 2020 •
edited

All Submissions:

This PR fixes the conflicts of #954:

This replaces the use of byte[][] in a number of places with a Tuple class that wraps it.
This is a necessary change to support doing anything other than blindly reading incoming data into a heap-allocated byte array.

The intended use-case is the flip side of #953. The actual functionality will follow in a subsequent PR if there's support for the refactor and feature.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Does mvn checkstyle:check pass ?
  3. Have you added your new test classes to an existing test suite in alphabetical order?

Changes to Existing Features:

  • Does this break existing behaviour? If so please explain.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

tomdcc and others added 3 commits September 21, 2017 14:34
@tomdcc
refactor: introduce tuple abstraction
b951588 
This replaces the use of byte[][] in a number of places with a Tuple
class that wraps it. This is a necessary change to support doing
anything other than blindly reading incoming data into a heap-
allocated byte array.
@tomdcc
docs: fix up copyright and add some javadoc
afe706e
Merge remote-tracking branch 'origin/master' into tuple-class
94ff921 
* origin/master: (427 commits)
  refactor: make PSQLState enum consts for integrity constraint violations (pgjdbc#1699)
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release REL42.2.10
  pass gpg key through arguments
  add passphrase to release mvn task
  chore: update signing key
  Metadata queries improvment (pgjdbc#1694)
  WIP release notes for 42.2.10 (pgjdbc#1688)
  chore(deps): bump checkstyle from 8.28 to 8.29 in /pgjdbc (pgjdbc#1691)
  Cleanup PGProperty, sort values, and add some missing to docs (pgjdbc#1686)
  fix: Fixes issue pgjdbc#1592 where one thread is reading the copy and another thread closes the connection (pgjdbc#1594)
  Fixing LocalTime rounding (losing precision) (pgjdbc#1570)
  sync error message value with tested value (pgjdbc#1664)
  add DatabaseMetaDataCacheTest to test suite to run it (pgjdbc#1685)
  Fix Network Performance of PgDatabaseMetaData.getTypeInfo() method (pgjdbc#1668)
  fix: Issue pgjdbc#1680 updating a boolean field requires special handling to set it to t or f instead of true or false (pgjdbc#1682)
  fix testSetNetworkTimeoutEnforcement test failure (pgjdbc#1681)
  minor: fix checkstyle violation of unused import (pgjdbc#1683)
  fix: pgjdbc#1677 NumberFormatException when fetching PGInterval with small value (pgjdbc#1678)
  fix: actually use milliseconds instead of microseconds for timeouts (pgjdbc#1653)
  ...
@paplorinc paplorinc mentioned this pull request Feb 10, 2020
Closed
davecramer
davecramer reviewed Feb 10, 2020
View reviewed changes
Copy link
Member

@davecramer davecramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which case use 2020

pgjdbc/src/main/java/org/postgresql/core/Tuple.java Show resolved Hide resolved
@paplorinc
Copy link
Contributor Author

@davecramer, could you please check if https://travis-ci.org/pgjdbc/pgjdbc/jobs/648367637?utm_medium=notification&utm_source=github_status is flaky or a valid failure?

@davecramer davecramer merged commit ed09fd1 into pgjdbc:master Feb 10, 2020
@paplorinc paplorinc deleted the tuple-class branch February 10, 2020 15:55
@paplorinc
Copy link
Contributor Author

Thanks for your quick review, @davecramer!

@paplorinc
Copy link
Contributor Author

Can you please close #954 as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davecramer davecramer davecramer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paplorinc @davecramer @tomdcc