fix: #1677 NumberFormatException when fetching PGInterval with small value #1678
Conversation
| days, | ||
| hours, | ||
| minutes, | ||
| wholeSeconds + microSeconds / 1e6d |
There was a problem hiding this comment.
I've started using TimeUnit.* to convert to and from time units. It's a bit more readable.
| @@ -367,20 +376,10 @@ public int getMicroSeconds() { | |||
| * @param seconds seconds to set | |||
| */ | |||
| public void setSeconds(double seconds) { | |||
| String str = Double.toString(seconds); | |||
| String str = String.format(Locale.ROOT,"%.6f",seconds); | |||
There was a problem hiding this comment.
Might be something like
wholeSeconds = (int) seconds
microSeconds = (seconds - wholeSeconds) / 1_000_000.0;There was a problem hiding this comment.
Well I have tried the _ thing and sadly java 6 doesn't understand it. Once we dump Java 6 we can use that.
If you really require double then just create a private static final CONSTANT. I'll be fine with that.
There was a problem hiding this comment.
Surely a constant can be introduced.
I mean that this operation can work only with numbers, without conversion to string.
and while discussing this, seems like there is an issue with getSeconds() which currently does
Double.parseDouble("" + wholeSeconds + '.' + microSeconds )
if wholeSeconds=1 and microSeconds=1 then result should be 1.000001 not 1.1
There was a problem hiding this comment.
I can introduce a constant and fix the getSeconds method. I'll just use the conversion logic from getValue.
In terms of the setSeconds logic, should 9e-7 be rounded nearest to 1 microsecond or can we just cast it down to 0?
There was a problem hiding this comment.
It would appear we need a few more test cases!
* origin/master: (427 commits) refactor: make PSQLState enum consts for integrity constraint violations (pgjdbc#1699) [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release REL42.2.10 pass gpg key through arguments add passphrase to release mvn task chore: update signing key Metadata queries improvment (pgjdbc#1694) WIP release notes for 42.2.10 (pgjdbc#1688) chore(deps): bump checkstyle from 8.28 to 8.29 in /pgjdbc (pgjdbc#1691) Cleanup PGProperty, sort values, and add some missing to docs (pgjdbc#1686) fix: Fixes issue pgjdbc#1592 where one thread is reading the copy and another thread closes the connection (pgjdbc#1594) Fixing LocalTime rounding (losing precision) (pgjdbc#1570) sync error message value with tested value (pgjdbc#1664) add DatabaseMetaDataCacheTest to test suite to run it (pgjdbc#1685) Fix Network Performance of PgDatabaseMetaData.getTypeInfo() method (pgjdbc#1668) fix: Issue pgjdbc#1680 updating a boolean field requires special handling to set it to t or f instead of true or false (pgjdbc#1682) fix testSetNetworkTimeoutEnforcement test failure (pgjdbc#1681) minor: fix checkstyle violation of unused import (pgjdbc#1683) fix: pgjdbc#1677 NumberFormatException when fetching PGInterval with small value (pgjdbc#1678) fix: actually use milliseconds instead of microseconds for timeouts (pgjdbc#1653) ...
Prevents getting a string with scientific notation by using an explicit format string. Uses a fixed precision which makes testing for the presence of decimal point and calculating a coefficient to get to microseconds unnecessary.
Fixes: #1677
All Submissions:
Changes to Existing Features: