New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: read only transactions #1252
Changes from 4 commits
edf54b4
72c9f0e
741b087
cdcf357
3d22199
27411e7
22c48f3
2b76735
bdf22c6
b8be807
5c8f6ae
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -404,6 +404,8 @@ private void executeInternal(CachedQuery cachedQuery, ParameterList queryParamet | |
|
||
if (connection.getAutoCommit()) { | ||
flags |= QueryExecutor.QUERY_SUPPRESS_BEGIN; | ||
} else if (connection.isTransactionReadOnly()) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would avoid There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. allowing some future change on the executor side to actually disentangle them? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I hate when flags are dependent. |
||
flags |= QueryExecutor.QUERY_READ_ONLY_HINT; | ||
} | ||
|
||
// updateable result sets do not yet support binary updates | ||
|
@@ -805,6 +807,8 @@ public int[] executeBatch() throws SQLException { | |
|
||
if (connection.getAutoCommit()) { | ||
flags |= QueryExecutor.QUERY_SUPPRESS_BEGIN; | ||
} else if (connection.isTransactionReadOnly()) { | ||
flags |= QueryExecutor.QUERY_READ_ONLY_HINT; | ||
} | ||
|
||
BatchResultHandler handler; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should just be 'get(properties)'