Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace some usages of initCause #1037

Merged
merged 1 commit into from Jan 12, 2018

Conversation

AlexElin
Copy link
Contributor

replace some usages of initCause with appropriate constructor

replace some usages of initCause with appropriate constructor
@codecov-io
Copy link

Codecov Report

Merging #1037 into master will increase coverage by <.01%.
The diff coverage is 37.5%.

@@             Coverage Diff              @@
##             master    #1037      +/-   ##
============================================
+ Coverage     66.39%   66.39%   +<.01%     
+ Complexity     3609     3607       -2     
============================================
  Files           168      168              
  Lines         15365    15355      -10     
  Branches       2495     2494       -1     
============================================
- Hits          10201    10195       -6     
+ Misses         3979     3974       -5     
- Partials       1185     1186       +1

@davecramer davecramer merged commit 0c29823 into pgjdbc:master Jan 12, 2018
@vlsi
Copy link
Member

vlsi commented Jan 12, 2018

@davecramer , frankly speaking, I do not like how refactor: replace some usages of initCause does change 40 unrelated lines.

On top of that, this change introduces little help, yet it introduces merge conflict with #935 that has been there for ages.

I'm inclined to revert #1037

@davecramer
Copy link
Member

fair enough, but lets get #935 in then

@vlsi
Copy link
Member

vlsi commented Jan 12, 2018

lets get #935 in then

Fair, but let's do that after 42.2.0?

@davecramer
Copy link
Member

sure..

davecramer added a commit that referenced this pull request Jan 12, 2018
davecramer added a commit that referenced this pull request Jan 12, 2018
@AlexElin AlexElin deleted the replace_initCause branch March 11, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants