Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatabaseMetaDataTest does not test binary mode #3229

Closed
davecramer opened this issue Apr 23, 2024 · 0 comments · Fixed by #3231
Closed

DatabaseMetaDataTest does not test binary mode #3229

davecramer opened this issue Apr 23, 2024 · 0 comments · Fixed by #3231

Comments

@davecramer
Copy link
Member

pgjdbc/pgjdbc/src/test/java/org/postgresql/test/jdbc2/DatabaseMetaDataTest.java

Line 54 in 8afde80

public void initDatabaseMetaDataTest(BinaryMode binaryMode) {

initDatabaseMetaDataTest does not run before setUp so binaryMode is null during setUp
davecramer referenced this issue Apr 24, 2024
@pmenke-de
Fix #3224 - conversion for TIME '24:00' to LocalTime breaks in binary…
8afde80 
…-mode (#3225)

* test: add tests for `TIME '24:00'` / LocalTime.MAX in binary-mode

add tests which verify, that conversion of binary-transferred TIME/TIMETZ `24:00` to LocalTime currently fails

* fix: handling of `TIME '24:00'` / LocalTime in binary-mode

fixes conversion of TIME/TIMETZ `24:00` to LocalTime from binary.
we now convert `24:00` to `LocalTime.MAX` instead of failing with `Invalid value for NanoOfDay`, which is now consistent with conversion from text.

* test: remove superfluous delete at end of test

`#setUp()` and `#tearDown()` manage the test-table's lifecycle. the test-table gets dropped at end of test anyway.
vlsi added a commit to vlsi/pgjdbc that referenced this issue Apr 24, 2024
@vlsi
test: sue binaryMode when creating connections in DatabaseMetaDataTest
997f51c 
pgjdbc#3229
vlsi added a commit to vlsi/pgjdbc that referenced this issue Apr 24, 2024
@vlsi
test: sue binaryMode when creating connections in DatabaseMetaDataTest
9a3c299 
pgjdbc#3229
@vlsi vlsi mentioned this issue Apr 24, 2024
Merged
vlsi added a commit to vlsi/pgjdbc that referenced this issue Apr 24, 2024
@vlsi
test: use binaryMode when creating connections in DatabaseMetaDataTest
b7775e8 
pgjdbc#3229
vlsi added a commit to vlsi/pgjdbc that referenced this issue Apr 24, 2024
@vlsi
test: test both binaryMode=true,false when creating connections in Da…
94de55b 
…tabaseMetaDataTest

pgjdbc#3229
vlsi added a commit to vlsi/pgjdbc that referenced this issue Apr 24, 2024
@vlsi
test: test both binaryMode=true,false when creating connections in Da…
57d1f10 
…tabaseMetaDataTest

pgjdbc#3229
vlsi added a commit to vlsi/pgjdbc that referenced this issue Apr 24, 2024
@vlsi
test: test both binaryMode=true,false when creating connections in Da…
eb93cea 
…tabaseMetaDataTest

pgjdbc#3229
@vlsi vlsi changed the title Broken tests DatabaseMetaDataTest does not test binary mode Apr 24, 2024
vlsi added a commit to vlsi/pgjdbc that referenced this issue Apr 24, 2024
@vlsi
test: test both binaryMode=true,false when creating connections in Da…
761d622 
…tabaseMetaDataTest

pgjdbc#3229
vlsi added a commit to vlsi/pgjdbc that referenced this issue May 10, 2024
@vlsi
test: test both binaryMode=true,false when creating connections in Da…
b9968f5 
…tabaseMetaDataTest

pgjdbc#3229
vlsi added a commit to vlsi/pgjdbc that referenced this issue May 10, 2024
@vlsi
test: test both binaryMode=true,false when creating connections in Da…
c0c129e 
…tabaseMetaDataTest

pgjdbc#3229
vlsi added a commit to vlsi/pgjdbc that referenced this issue May 10, 2024
@vlsi
test: test both binaryMode=true,false when creating connections in Da…
89bd14c 
…tabaseMetaDataTest

pgjdbc#3229
vlsi added a commit to vlsi/pgjdbc that referenced this issue May 10, 2024
@vlsi
test: test both binaryMode=true,false when creating connections in Da…
0ea6c9b 
…tabaseMetaDataTest

pgjdbc#3229
vlsi added a commit to vlsi/pgjdbc that referenced this issue May 10, 2024
@vlsi
test: test both binaryMode=true,false when creating connections in Da…
dc863f5 
…tabaseMetaDataTest

pgjdbc#3229
vlsi added a commit to vlsi/pgjdbc that referenced this issue May 10, 2024
@vlsi
test: test both binaryMode=true,false when creating connections in Da…
7a4dbd9 
…tabaseMetaDataTest

pgjdbc#3229
vlsi added a commit to vlsi/pgjdbc that referenced this issue May 10, 2024
@vlsi
test: test both binaryMode=true,false when creating connections in Da…
4956902 
…tabaseMetaDataTest

pgjdbc#3229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: test both binaryMode=true,false when creating connections in DatabaseMetaDataTest vlsi/pgjdbc
1 participant
@davecramer