Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numeric precision should not be 131089 #2188

Closed
davecramer opened this issue Jun 23, 2021 · 1 comment
Closed

Numeric precision should not be 131089 #2188

davecramer opened this issue Jun 23, 2021 · 1 comment

Comments

@davecramer
Copy link
Member

In the case where numeric precision is not specified in the type ie numeric(8,2) we are currently returning the display size which is certainly incorrect.

pgjdbc/pgjdbc/src/main/java/org/postgresql/jdbc/PgDatabaseMetaData.java

Line 1650 in 7aea513

if (columnSize == 0) {

I'm inclined to fix this and backpatch it as it is a bug, however I'm a little concerned at breaking something. OTOH, it's clearly wrong.
@lukaseder lukaseder mentioned this issue Jun 23, 2021
Closed
davecramer added a commit to davecramer/pgjdbc that referenced this issue Jun 23, 2021
@davecramer
Fix: fix getColumnPrecision for Numeric when scale and precision not …
8c9bd89 
…specified fixes: Issue pgjdbc#2188
davecramer added a commit that referenced this issue Jul 2, 2021
@davecramer
Fix: fix getColumnPrecision for Numeric when scale and precision not …
2f39510 
…specified fixes: Issue #2188 (#2189)

* Fix: fix getColumnPrecision for Numeric when scale and precision not specified fixes: Issue #2188
davecramer added a commit to davecramer/pgjdbc that referenced this issue Jul 2, 2021
@davecramer
fix getColumnPrecision for Numeric when scale and precision not speci…
c4cacb5 
…fied fixes: Issue pgjdbc#2188
davecramer added a commit that referenced this issue Jul 2, 2021
@davecramer
fix getColumnPrecision for Numeric when scale and precision not speci…
70f576c 
…fied fixes: Issue #2188 (#2203)
@davecramer
Copy link
Member Author

closed by #2189

@sync-by-unito sync-by-unito bot mentioned this issue Jul 7, 2021
Merged
@judahrand judahrand mentioned this issue Sep 30, 2021
Merged
judahrand added a commit to judahrand/debezium that referenced this issue Oct 5, 2021
@judahrand
DBZ-4046 Update isVariableScaleDecimal
0a780cc 
This puts the method in line with
pgjdbc/pgjdbc#2188
where expected value was changed from `131089` to `0`.
However, for numeric arrays the issue remains and so
`131089` remains the correct value for them.
gunnarmorling pushed a commit to debezium/debezium that referenced this issue Oct 8, 2021
@judahrand @gunnarmorling
DBZ-4046 Update isVariableScaleDecimal
5d23b30 
This puts the method in line with
pgjdbc/pgjdbc#2188
where expected value was changed from `131089` to `0`.
However, for numeric arrays the issue remains and so
`131089` remains the correct value for them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davecramer