Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta should not produce precision 131089 for PostgreSQL numeric types without precision #12040

Closed
lukaseder opened this issue Jun 22, 2021 · 2 comments

Comments

@lukaseder
Copy link
Member

lukaseder commented Jun 22, 2021

The JDBC backed Meta implementation produces a precision of 131089 for a table like this:

create table t (implicit_precision text)

This is what the JDBC driver produces, too:

try (Statement s = connection.createStatement()) {
    try {
        s.executeUpdate("create table t (implicit_precision text)");
        try (ResultSet rs = connection.getMetaData().getColumns(null, "public", "t", "%")) {
            while (rs.next()) {
                System.out.println(rs.getInt(7));
            }
        }
    }
    finally {
        s.executeUpdate("drop table if exists t");
    }
}

See also:

We should ignore that precision.

@lukaseder
Copy link
Member Author

The current state of discussion is that pgjdbc seems to fix this. I'm postponing any action here for now. It won't go into 3.15.0. If this gets fixed, it will be backported to a 3.15.x release.

@lukaseder lukaseder removed this from To do in 3.15 Other improvements Jul 1, 2021
@lukaseder
Copy link
Member Author

lukaseder commented Jul 5, 2021

pgjdbc/pgjdbc#2188 was fixed by removing the "magic" COLUMN_SIZE value 131089 for NUMERIC column types, meaning I won't fix this issue in jOOQ.

@lukaseder lukaseder added this to To do in 3.15 Other improvements via automation Jul 5, 2021
@lukaseder lukaseder moved this from To do to Done in 3.15 Other improvements Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant