Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: Add test for logServerErrorDetail connection property
- Loading branch information
Showing
2 changed files
with
102 additions
and
0 deletions.
There are no files selected for viewing
100 changes: 100 additions & 0 deletions
100
pgjdbc/src/test/java/org/postgresql/test/core/LogServerMessagePropertyTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,100 @@ | ||
/* | ||
* Copyright (c) 2019, PostgreSQL Global Development Group | ||
* See the LICENSE file in the project root for more information. | ||
*/ | ||
|
||
package org.postgresql.test.core; | ||
|
||
import org.postgresql.PGProperty; | ||
import org.postgresql.core.ServerVersion; | ||
import org.postgresql.test.TestUtil; | ||
|
||
import org.junit.Assert; | ||
import org.junit.Assume; | ||
import org.junit.Test; | ||
|
||
import java.sql.Connection; | ||
import java.sql.SQLException; | ||
import java.util.Properties; | ||
|
||
public class LogServerMessagePropertyTest { | ||
private static final String PRIMARY_KEY_NAME = "lms_test_pk"; | ||
private static final String CREATE_TABLE_SQL = | ||
"CREATE TABLE pg_temp.lms_test (" | ||
+ " id text, " | ||
+ " CONSTRAINT " + PRIMARY_KEY_NAME + " PRIMARY KEY (id)" | ||
+ ")"; | ||
private static final String SECRET_VALUE = "some_secret_value"; | ||
private static final String INSERT_SQL = | ||
"INSERT INTO pg_temp.lms_test (id) VALUES ('" + SECRET_VALUE + "')"; | ||
private static final String UNIQUE_VIOLATION_SQL_STATE = "23505"; | ||
|
||
/** | ||
* Creates a connection with the additional properties, use it to | ||
* create a temp table with a primary key, run two inserts to generate | ||
* a duplicate key error, and finally return the exception message. | ||
*/ | ||
private static String testViolatePrimaryKey(Properties props) throws SQLException { | ||
Connection conn = TestUtil.openDB(props); | ||
Assume.assumeTrue(TestUtil.haveMinimumServerVersion(conn, ServerVersion.v9_1)); | ||
try { | ||
TestUtil.execute(CREATE_TABLE_SQL, conn); | ||
// First insert should work | ||
TestUtil.execute(INSERT_SQL, conn); | ||
// Second insert should throw a duplicate key error | ||
TestUtil.execute(INSERT_SQL, conn); | ||
} catch (SQLException e) { | ||
Assert.assertEquals("SQL state must be for a unique violation", UNIQUE_VIOLATION_SQL_STATE, e.getSQLState()); | ||
return e.getMessage(); | ||
} finally { | ||
conn.close(); | ||
} | ||
// Should never get here: | ||
Assert.fail("A duplicate key exception should have occurred"); | ||
return null; | ||
} | ||
|
||
private static void assertMessageContains(String message, String text) { | ||
if (message.toLowerCase().indexOf(text.toLowerCase()) < 0) { | ||
Assert.fail(String.format("Message must contain text '%s': %s", text, message)); | ||
} | ||
} | ||
|
||
private static void assertMessageDoesNotContain(String message, String text) { | ||
if (message.toLowerCase().indexOf(text.toLowerCase()) >= 0) { | ||
Assert.fail(String.format("Message must not contain text '%s': %s", text, message)); | ||
} | ||
} | ||
|
||
@Test | ||
public void testWithDefaults() throws SQLException { | ||
Properties props = new Properties(); | ||
String message = testViolatePrimaryKey(props); | ||
assertMessageContains(message, PRIMARY_KEY_NAME); | ||
assertMessageContains(message, "Detail:"); | ||
assertMessageContains(message, SECRET_VALUE); | ||
} | ||
|
||
/** | ||
* NOTE: This should be the same as the default case as "true" is the default. | ||
*/ | ||
@Test | ||
public void testWithExplicitlyEnabled() throws SQLException { | ||
Properties props = new Properties(); | ||
props.setProperty(PGProperty.LOG_SERVER_ERROR_DETAIL.getName(), "true"); | ||
String message = testViolatePrimaryKey(props); | ||
assertMessageContains(message, PRIMARY_KEY_NAME); | ||
assertMessageContains(message, "Detail:"); | ||
assertMessageContains(message, SECRET_VALUE); | ||
} | ||
|
||
@Test | ||
public void testWithLogServerErrorDetailDisabled() throws SQLException { | ||
Properties props = new Properties(); | ||
props.setProperty(PGProperty.LOG_SERVER_ERROR_DETAIL.getName(), "false"); | ||
String message = testViolatePrimaryKey(props); | ||
assertMessageContains(message, PRIMARY_KEY_NAME); | ||
assertMessageDoesNotContain(message, "Detail:"); | ||
assertMessageDoesNotContain(message, SECRET_VALUE); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters