Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python 3.12 #334

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Support python 3.12 #334

merged 2 commits into from
Apr 10, 2024

Conversation

kuenishi
Copy link
Member

Addresses #333 .

@kuenishi kuenishi added the cat:enhancement Implementation that does not break interfaces. label Apr 10, 2024
@kuenishi kuenishi added this to the 2.8.0 milestone Apr 10, 2024
@kuenishi kuenishi self-assigned this Apr 10, 2024
@kuenishi
Copy link
Member Author

The CI is failing for sparse file cache, which is a deprecated feature.

=================================== FAILURES ===================================
______________________________ test_s3_zip[True] _______________________________

local_cache = True

    @mock_aws
    @pytest.mark.parametrize("local_cache", [False, True])
    def test_s3_zip(local_cache):
        with tempfile.TemporaryDirectory() as d:

So I decided to remove it beforehand at #335.

@kuenishi kuenishi merged commit 8768f9e into master Apr 10, 2024
11 checks passed
@kuenishi kuenishi deleted the python312 branch April 10, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement Implementation that does not break interfaces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant