Required changes to support nodenext #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nodenext` style resolution ignores the top-level `types` reference when there's an `exports`. A `types` in the various exports is required.
In a multi-type module like this, where you offer both import and require, don't set the `type` field. The `type` field forces TypeScript module resolution to see the whole package as a `module` before it even evaluates the `nodenext`.
|
@petrzjunior Hi! What are the odds of getting this merged this week? We unfortunately have to currently run with a patched version of the module in order to get our project to build. |
|
@bytenik Thank you for your contribution, I'll merge it ASAP, sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodenextstyle resolution ignores the top-leveltypesreference when there's anexports. Atypesin the various exports is required.Also, in a multi-type module like this, where you offer both import and require, don't set the
typefield. Thetypefield forces TypeScript module resolution to see the whole package as amodulebefore it even evaluates thenodenext. This isn't either module or commonjs; its both, depending on the consumer. Even withoutnodenext, settingmainandmoduleproperties handles this correctly without thetype.