Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test #1

wants to merge 3 commits into from

Conversation

petreeftime
Copy link
Owner

No description provided.

@petreeftime
enable KMS key testing
63d1157 
Signed-off-by: Petre Eftime <epetre@amazon.com>
@petreeftime
ci: use env instead of secret variable
85600ed 
It seems like the CI doesn't allow any PR to access the secrets store.
Since the Role Arn is not really a secret and the role itself is scoped
down to access the test key and nothing else, there is limited risk in
having it available as an env variable, but should hopefully allow for
testing PRs, although it does make setting up testing in a fork slightly
more challenging.

Signed-off-by: Petre Eftime <epetre@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@petreeftime