Add VisitMap::unvisit as proposed in #610
#611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
aalekhpatel07
changed the title
VisitMap::unmark as proposed in #610VisitMap::unvisit as proposed in #610
bluss
reviewed
Mar 1, 2024
src/visit/mod.rs
Outdated
| /// | ||
| /// Return **true** if this vertex was marked as visited at the time of unsetting it, false otherwise. | ||
| fn unvisit(&mut self, _a: N) -> bool { | ||
| unimplemented!("We don't know how to mark the node as unvisited.") |
There was a problem hiding this comment.
Could it be avoided to have a default implementation? Instead leave this out and let it be a breaking change, that's the principled approach at least.
There was a problem hiding this comment.
Yeah we could totally get by without a default implementation. My initial idea was to not make this a breaking change but an additional feature that is backwards compatible. I don't have a strong preference but if breaking change is preferable, then lets go ahead with that.
Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the
VisitMap::unvisitmethod as proposed in #610 .