refactor: Remove unused macro and impl Clone for Node, Edge, Neighbor #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cauliyang
changed the title
|
Hi, maintainer @indietyp @AlexTMjugador! I am reading and learning from the codebase and found we may be able to reduce some "outdated" and unused code. What do you think? Thanks for your time! |
|
The code is going to undergo a major refactoring in 0.7.0 so I am a bit hesitant to merge this. My schedule finally freed up a bit, so I am able to spend more time on it. |
|
make sense. I notice that the codebase is undergoing "big change" so I try to minimize the scope of change. Anyways, thanks for your answer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.