-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out petgraph
into separate crates
#561
Conversation
petgraph
into seperate cratespetgraph
into separate crates
Progress Report
Everything compiles with the default feature sets, and all tests pass.
|
Progress Report
The algorithms crate is by far the most challenging one; some algorithms require specific graphs (like |
Progress Report
|
Progress Report
While trying to upgrade to proptest I noticed that our quicktest is really feasible in quicktest 1.0 and likely also doesn't correctly shrink. I have taken the liberty to transfer to The code is now generic and can easily be implemented for all kinds of graphs as well is configurable, so if users do not like the default, they can just call Crates compile (again). Due to the very nature of what we're trying to do (separating the concerns, making things more maintainable, etc.), there are quite a handful of new crates; they are now grouped under The only thing missing are now moving the tests (and testing^^) |
Progress Reportquite a lot of tests have been ported; remaining are:
|
Phew, well, that took a bit longer than expected. Finally, all tests have been converted and rewritten. This whole thing not only separated everything into separate crates but also had the nice side-effect that tests are now more readable and in places where one expects them. The only thing that needs to be added now is going through with cargo-hack and move the benches. |
Sadly things came in between me and being able to work on this, but after some major rework of all the benchmarks (which if I do say so, are a lot easier to read now), we're ready! |
This is quite a large PR 😅 (but it's mostly just moving stuff around). I'll wait for any comments until the end of the week (or until I get approval) and then merge them into the |
visit
deprecated, available inpetgraph-core
data
deprecated, available inpetgraph-core
IndexType
topetgraph-core
EdgeType
, and related topetgraph-core
IndexType
to make use offunty